Repository navigation
Release v1.7.0 - #58
Merged
Merged
Conversation
The frames that read the gamepad first (the chord watcher while a chord's first button is held, a Ding window's) relied on the handler's return value to let a button through; the client reads the frame's input propagation instead, so every button was kept: with RB held for RB + Up, LB + RB + Left / Right (action bar pages) and + Down (chat) did nothing. Each handler now sets the propagation for the button it read (out of combat), and the mock client does the same as the game. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The button forgot the character's place and went back to the first step still to do: with Elite quests turned on, a player at step 38 of the Wetlands was sent back to step 5, an elite quest never taken. It now forgets the marks only and takes the section up to the player's place with a strict resume: it stops on a quest of the log with work left or a quest of the route still to take (not optional, not behind an option, open now); what was left behind on purpose passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Minimizing the guide window in combat was on by default; it is now an option, off (the user's choice). Settings from before v1.7.0 (layout 3) drop the old default once; turned on again, it stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…option on Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…side Registers "Ding! - Dungeon quests" (ding-dungeons, builtin 5, category "dungeon"): the Guide tab lists the character's side only, by level. A go step at a dungeon's entrance now passes once the character is inside an instance, where the game gives no position (Compat.InInstance, Data:DungeonAtEntrance, checked on PLAYER_ENTERING_WORLD). check_guides knows the pack and its category. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks the dungeon's quests open to the side, their prerequisites, breadcrumbs, drop-started quests and follow-ups, places each action before, inside or after the dungeon, and orders the trips with route_travel. Raids, set chains, professions, repeatables and long class chains are left out and listed in a report. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Classic dungeons from Ragefire Chasm to Stratholme, Lower Blackrock Spire included, and Forever's Hall of Thanes, Ruins of Lordaeron, Excavation Site: Wetlands and City of Dalaran: the quest givers and their chains, the entrance, one step per objective with a note saying where, then the turn-ins and follow-ups. dungeon_quests_test covers the pack, the section list, the assistant, the entrance passed from inside and the data; the smoke test expects the new header. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SPEC and guide-packs describe the "dungeon" category and the entrance step passed from inside an instance; architecture, CLAUDE.md and the tools README list the guides and draft_dungeon.lua; README gains the feature line and CHANGELOG the v1.7.0 entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
874 texts added to each tools/routes/locales dictionary (frFR, deDE, esES, ptBR, koKR, zhCN, zhTW); translate_guides.lua writes the 287 guide translations and their TOC lines. Names the game has no translation for (Forever's NPCs, quests and items) stay in English. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A tester was told he had arrived while still a few steps away: a place or an NPC was reached at 10 yards (the arrow then faded) and a kill or gather area at 40 yards from a spawn, beyond an attack's reach. Now 6 yards (Engine DEFAULT_RADIUS, Arrow ARRIVE) and 25 / 40 yards for areas. The aids are on for a new install: far enemy nameplates join the marks and the tooltip line. The marks sit on the enemy nameplates, which the client hides until V: Ding shows them once, out of combat, says so in the chat, and never forces them again (Ding.db.platesShown). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-c75de0 # Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v1.7.0: integrates #55 (dungeon quests pack, 41 guides), #57 (floor hints on arrival) and v1.6.1 (#56), plus fixes from in-game tests:
Checks: tools/check_all.sh ALL GREEN (81 test files, 12 smoke runs), release_test green, DingDB unchanged. Installed in game.
🤖 Generated with Claude Code