Repository navigation
Release v1.8.1 - #62
Merged
Merged
Conversation
Since v1.7.1 E:ObjectiveDone built Data:ObjectiveTargets (every spawn of every target) on each call; Grind calls it for each objective of each log quest it weighs, and the smoke runs took 3.5 times as long (249 s instead of 72 for the Alliance leveling chain). It now matches the name in the objective's text first, and keeps the targets used for matching by rank once per quest. Back to 71 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v1.8.1: v1.8.0 (Problem with this step?, #60/#61; its publication was cancelled) plus a performance fix.
Since v1.7.1, E:ObjectiveDone built Data:ObjectiveTargets (every spawn of every target) on each call; Grind calls it for each objective of each log quest it weighs on level steps. The smoke runs took 3.5 times as long (249 s instead of 72 s for the Alliance leveling chain; the CI test jobs went past 1.5 h). It now matches the name in the objective's text first and keeps the targets used for matching by rank once per quest: 71 s.
Checks: tools/check_all.sh ALL GREEN in 314 s (83 test files, 12 smoke runs), release_test green. Installed in game.
🤖 Generated with Claude Code