Skip to content

refactor(script): make family dispatch exhaustive #80

Closed

Description

@mowind

Parent

#78

What to build

Make Script select Ethereum, Optimism, and Tempo execution through a direct exhaustive match on the canonical resolved EvmFamily, while preserving Script-owned capability and broadcast behavior.

Tempo must retain both ordinary broadcast and batch broadcast, including verification continuation. Ethereum and Optimism must retain their existing generic execution paths. Non-Tempo --batch invocations must continue to fail with the existing user-facing contract.

This is a Script-local hardening change. It must not move batch policy into a shared dispatcher or introduce a routing helper solely for testing.

Acceptance criteria

  • Script directly matches the canonical EvmFamily, explicitly naming Ethereum, Optimism, and Tempo without a wildcard, default arm, or inferred Ethereum fallback.
  • Ethereum and Optimism retain their existing generic Script execution and broadcast behavior.
  • Tempo retains ordinary broadcast, batch broadcast, pending-transaction handling, and verification continuation.
  • Non-Tempo --batch continues to fail before execution with the existing diagnostic and exit behavior.
  • A focused command-level regression test covers non-Tempo --batch rejection, asserting failure status, empty stdout, and the existing stderr diagnostic.
  • Existing ordinary Tempo Script command coverage and Tempo end-to-end checks for successful batch broadcast and atomic batch failure remain green.
  • Profile resolution, fork identity resolution, EVM construction, Forge, Cast, Chisel, Verify bytecode, and Anvil remain unchanged.
  • No shared helper, macro, trait, dispatcher, registry, sum type, new public seam, or test-only routing seam is introduced.
  • A final source audit finds no catch-all family projection in Script execution.
  • Rust formatting and focused Script validation pass with the HashKey feature enabled.

Blocked by

None — can start immediately.

Activity

  1. added a commit that references this issue on Aug 5, 2026
    7f08fec
  2. mowind commented on Aug 5, 2026

    @mowind
    OwnerAuthor

    Implemented in 7f08fec (refactor(script): match canonical EvmFamily exhaustively).

    • Script execution now matches the canonical resolved EvmFamily directly, explicitly naming Ethereum, Optimism, and Tempo — no wildcard, default arm, or inferred fallback.
    • Ethereum/Optimism keep the generic execution path; Tempo keeps ordinary broadcast, batch broadcast, pending-transaction handling, and verification continuation.
    • Non-Tempo --batch still fails before execution with the existing diagnostic.
    • Added script_batch_rejects_non_tempo_network (failure + empty stdout + existing stderr) and script_batch_broadcasts_on_tempo (single shared batch tx hash across all calls).
    • No shared helper, dispatcher, or new seam introduced; source audit confirms no catch-all family projection remains in Script execution.
    • Full workspace suite (hashkey feature): 2115 passed; the 12 failures are pre-existing (cast opts stack-overflow, SVM multi-compiler listing, external integrations), unrelated to this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ready-for-agentFully specified and ready for an AFK agent

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions