-
Notifications
You must be signed in to change notification settings - Fork 44
chore: reorganize navigation #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3718cc3 to
2432e57
Compare
NAVIGATION STRUCTURE
|
|
I haven't had a chance to look through all the changes, but just some thoughts on the section headers since I think that's the main goal if this PR. Regarding the Data & Analysis section:
|
|
Thnx for looking @mikewilli I reorganized the data sections from your suggestions. The sizing article was contributed by Daniel and just talks about the math and principles of sizing. The sizing cli article is about how to use a sizing tool inside mozanalysis and the flags for it etc. Now the section about the actual analysis is called Analysis, and down later Jetstream Operations is all about the infra and testing/maintenance/etc.
|
|
@jaredlockhart do we have labs content too in the docs? |
|
@yashikakhurana I don't think so? I don't see one on the current site? Maybe @freshstrangemusic didn't write it yet? |
| ## Find an existing experiment | ||
|
|
||
| If the experiment was run with Nimbus, check out the [directory of live and completed experiments](https://experimenter.services.mozilla.com/nimbus/). Normandy experiments can be found [here](https://experimenter.services.mozilla.com/). | ||
| Check out the [directory of live and completed experiments](https://experimenter.services.mozilla.com/nimbus/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we update these links to point to the home page? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh but that specific line says 'directory of live and complete experiments' which is on the table view, which is what it's linking to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry I meant where it is necessary, because I don't think we have updated the links like here- Experimenter Console (Production)
Experimenter Console (Stage)
yashikakhurana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, thank you for organizing this, apart from updating the links to the home page, feel free to merge this, thank you @jaredlockhart
|
Much better, thanks! I think we'll want to clean up and maybe consolidate the sizing information -- there's at least 3 pages that refer to Sizing in the header now -- but that can be separate from this first pass. |
Because * We can reorganize the navigation to make it easier to find things This commit * Reorganizes the tree structure * Renames articles to have shorter titles fixes #725
|
@yashikakhurana Okay ya good call, I updated the links to point to either the home page where appropriate, or the table page where appropriate. And yes @mikewilli exactly, that's the next PR ;D |
Because
This commit
fixes #725