feat(nimbus): add results indicator next to metric slug in metric area headers

[moibra05]

Because

• Upon first visiting the new results page it is unclear the results of the experiment and whether there were any significant changes

This commit

• Adds an arrow indicator next to the metric names to indicate how that experiment affected that particular metric
• Fixed an issue where metrics would incorrectly be placed in the "Notable Changes" section

Fixes #14460

[moibra05]

[mikewilli]

Seeing this, it really drives home that the answer to "was the overall significance of this metric positive or negative?" is quite a bit more nuanced than it sounds. I wonder if it'd be better to simply annotate them with statuses instead. Something like:

• ❗ Notable metric change
• ❌ Metric missing results
• (no special styling/icon) No error or notable change

What do you think?

[jaredlockhart]

Oh yeah I think I suggested four possible states

1. All neutral
2. Neutral or positive
3. Neutral or negative
4. Mixed (neutral, positive, negative)

But you're right @mikewilli there's also a case for

5. Missing data

I think that should cover all the states.

Yeah theoretically we could fold any positive/negative together into a 'notable results' I just think it would be great to see all the directionality in one zoomed out view before you zoom in, which we don't have right now. If we find it's confusing or misleading we can always change it later.

[moibra05]

Oh yeah I think I suggested four possible states

1. All neutral

2. Neutral or positive

3. Neutral or negative

4. Mixed (neutral, positive, negative)

But you're right @mikewilli there's also a case for

5. Missing data

I think that should cover all the states.

Yeah theoretically we could fold any positive/negative together into a 'notable results' I just think it would be great to see all the directionality in one zoomed out view before you zoom in, which we don't have right now. If we find it's confusing or misleading we can always change it later.

Yep, I planned to address better ui for metrics that are missing data in a different pr

[jaredlockhart]

Oh the double arrows means mixed! That's clever, but actually I'd use up/down together since we're using up and down already for each of positive and negative.

[jaredlockhart]

Yep this is all looking good! Try playing with set and see if it helps, otherwise this should be good to land 🎉

[jaredlockhart]

Perfect 🙏

[jaredlockhart]

Nice 🙏

made changes