This repository was archived by the owner on Jan 29, 2025. It is now read-only.
Fix CI status by moving docs deployment to GHA#2358
Open
janbrasna wants to merge 10 commits intomozilla:masterfrom
Open
Fix CI status by moving docs deployment to GHA#2358janbrasna wants to merge 10 commits intomozilla:masterfrom
janbrasna wants to merge 10 commits intomozilla:masterfrom
Conversation
This version is already tagged and running in prod, just making sure it's also correctly output upon installing.
Deployment now handled via GHA; build to test is kept in the pipeline.
Author
|
You can check the sample run for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the CircleCI secrets only have read-only access scope for the GitHub token, being unable to write the built docs to
gh-pagesbranch. It's the only failure in the pipeline, and instead of providing write permissions it may be easier to just move the actual docs deployment to GitHub Actions, avoiding any commits to the pages' branch and publishing straight to the deployment env without any underlying git tree being written etc.This PR keeps the
docs-buildstep in CI for consistency in testing, only removing the actualdocs-publishand creating a workflow here instead.Note
To enable Pages publishing via Actions, you may need to to change the publishing source in repo settings for this workflow to take over, and also make sure if there are any env protections defined they also include "master" and not "gh-pages" only.)
Once you're happy with the trigger-based deploys from master, you can safely remove the
gh-pagesbranch completely (which hasn't received updates for more than two years) as it won't be used anymore, and also remove thetschaub/gh-pagesyarn dev dependency and relevant scripts as all docs will be published from master branch deploys automatically from that point on.