chore(mozilla_workgroup): improve v1 v2 compatibility#445
Merged
Conversation
whd
added
minor
Member
Author
|
Marking as major because we've never cut a new style release for this module, see https://mozilla-hub.atlassian.net/browse/MZCLD-2140 |
Contributor
Release plan
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes some longstanding incompatibility issues between v1 and v2 outputs due to BQ ACL and service account output generation by:
[]if remote state doesn't contain themThis shouldn't change the behavior for any current usage of the module, it should just make some input configuration unnecessary by exposing more information by default and gracefully returning nothing instead of erroring. This has the potential to be confusing to someone who is trying to look up service accounts using the v2 module when those SAs are only defined in v1 but I highly doubt anybody will run into this situation.
Related Tickets & Documents