Port to Django 1.6#1769
Conversation
There was a problem hiding this comment.
For every requirement you had to fork, we need to push for a new release with your fixes. Let's try to avoid keeping forks around.
There was a problem hiding this comment.
links for dependency PRs added.
|
So, I realize this is going to be annoying, but I think we need to split this PR up. I'd like to have at least the version-related changes and the fixtures changes in separate PRs to make it easier to review and spot regressions. The most backwards-compatible changes we can merge before the actual switch to 1.6, the better. |
|
I agree that splitting things up is better. I'll see what I can do. |
|
preliminary changes moved to #1774 |
|
preliminary changes merged. |
There was a problem hiding this comment.
This shouldn't be necessary with the removal of the version magic, or something is wrong.
There was a problem hiding this comment.
Something must be wrong then, because removing this causes get_localepicker to fail.
There was a problem hiding this comment.
Even if you self.addon.reload() ?
Edit:* It could be because the File we create has the wrong status actually.
There was a problem hiding this comment.
reload() works here without that update.
|
r+wc from me if tests pass after rebasing against master :) |
|
well I merged this and now both CI and -dev deploy are broken with no meaningful errors. reverting until I can get ops help. |
This reverts commit 62d75b2.
3 participants
These are the last few changes needed for Django 1.6 compatibility.
PRs for dependencies:
jbalogh/test-utils#25
mozilla/nuggets#4