refactor: replace claims/rewards with items system - #12
Merged
Conversation
…d modules - Add new items system (client features/items, server src/items, types src/items) - Remove legacy claims module (client + server + types/claims) - Remove shared/rewards.service.ts, shared/constants.ts, shared/shared.module.ts - Move pet decay logic to shared calculateDecayedNeeds() utility in types - Replace RewardsService with ItemsService in PetsService - Remove pet actions/valentine modules and PetActionCategory type - Add MAX_EXPEDITION_SLOTS_RATIO and ItemResult to types exports - Add notifications.constants.ts and users.constants.ts - Update i18n locale files (en/ru) for new item-related keys - Update actionSprites data and pet entity with needsUpdatedAt field Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
🚅 Deployed to the widgetable-pr-12 environment in widgetable
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claimsmodule (client, server, types) with a unifieditemssystemshared/rewards.service.ts,shared/constants.ts, andshared/shared.module.ts; consolidate shared logic intoItemsServicecalculateDecayedNeeds()utility in@widgetable/typesnotifications.constants.tsandusers.constants.tsto separate magic values from service filesTest plan
ItemsServicecalculateDecayedNeeds()utilityMAX_EXPEDITION_SLOTS_RATIOfrom typesnpm run tsc && npm run lint)