Repository navigation
README: note offline theme checks and read-key silencing worker audio - #62
Merged
Merged
Conversation
play-theme validates a theme before the music starts, so a game's tests can check its grids with no audio. Under lg -w, read-key parks the whole worker (nooga/let-go#1086), which stops the renderer; polling key-pending? with a sleep keeps it running. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drum lanes are neither length- nor character-checked, and they run to 32 sixteenths, so "a lane longer than 16 steps" overstated the check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Review (medium) addressed at the head commit: 1 and 2. The theme-check note overstated what is checked. Fixed. The README now names what The worker-mode note is unchanged. Its workaround was measured in a browser, as the description says. |
mparrett
force-pushed
the
readme-worker-notes
branch
from
October 20, 2026 14:57
a5a83f6 to
ff9a4c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two README notes from the xsofy audio work (mparrett/xsofy#53):
play-themevalidates its grids at once, even while the theme waits formusic-start, so a game's tests can check its themes with no audio.read-keysilences worker-mode audio. Underlg -w, let-go'sread-keyparks the whole worker with no timeout, sowebaudio's render goroutine stops until a key arrives. Filed upstream as lg -w: read-key blocks every goroutine while it waits for a key nooga/let-go#1086. The workaround is to pollterm/key-pending?with asleep. It was checked in headless Chromium on 2026-10-20, on xsofy's message log (xsofy#53 at 83ab040, undertone f1c6c56, seed 976699241). Over 6 s with the log open, peak RMS was 0.2085 polling with a 10 ms sleep (0.2004 on a rerun), and 0.0 with a plainread-key.tui: run modal screens on the poll loop instead of blocking reads nooga/xsofy#200 applies the same pattern across xsofy: it moves its nine blocking
read-keysites onto a polling run loop. Merged with xsofy#53 and tested 2026-10-20, the message log, help, inventory and quit-confirm screens each kept a peak RMS of 0.18–0.21.🤖 Generated with Claude Code