switched RadixHeapMap::push() to return a Result#12
Open
ripytide wants to merge 1 commit intompdn:masterfrom
Open
switched RadixHeapMap::push() to return a Result#12ripytide wants to merge 1 commit intompdn:masterfrom
RadixHeapMap::push() to return a Result#12ripytide wants to merge 1 commit intompdn:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched
RadixHeapMap::push()to return a Result rather than simply panicking when given a greater key than the current top key.This is a nicer API to work with as it allows the caller to choose how they want to handle such an error rather than being forced to panic.
The use-case that inspired this change was I was trying to debug a scenario when a greater key was given by catching the faulty
pushand doing somedbg!()s but I was unable to sincepush()panics internally.