fix: correct submenu ordering and icon placement on android#176
Open
AshleyField wants to merge 1 commit into
Open
fix: correct submenu ordering and icon placement on android#176AshleyField wants to merge 1 commit into
AshleyField wants to merge 1 commit into
Conversation
Contributor
Author
|
@mpiannucci any chance of getting a review on this? Thanks so much 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken
On Android parent items with a submenu we're causing two layout problems:
What this fix does
Screenshots
On the before, the 'Transparent' item should have a trash icon and the 'More Actions' item should have a circle icon. However the icon has been bumped off the 'Transparent' menu item and replaced by the 'More Actions' icon.
Also on before, all menu items that contain a submenu have been bumped to the top of the list, rather than respecting the order they've been added to the list.