Open
Conversation
if old_fanpy is True it uses fanpy only for calcs if old_fanpy is False it uses PyCI for calcs
removed nproj added geom and basis args
This now is uniform between the gaussian and pyscf parser
if calc range specified i is a number (corresponding folder is _i) if no range specified i is the folder name. No underscore needed.
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and bug fixes to the PySCF and Gaussian calculation scripts in the
fanpypackage, focusing on argument parsing, default parameter handling, and test coverage. The main changes include standardizing argument types and defaults, improving script generation for PySCF workflows, and adding comprehensive tests for these scripts.Argument parsing and default handling improvements:
run_calcfunction infanpy/scripts/gaussian/run_calc.pyto use explicit default values fornuc_nuc,pspace_exc,objective, andsolverparameters, improving reliability and usability.--optimize_orbsargument infanpy/scripts/pyscf/pyscf_parser.pyto useaction="store_true"for correct boolean flag behavior, and updated--pspace_excto accept a string for easier CLI parsing.fanpy/scripts/pyscf/make_fanci_script.pyto parsepspace_excfrom a string to a list of integers, ensuring correct data types are passed to downstream functions.Script generation and interface enhancements:
write_wfn_pyinfanpy/scripts/pyscf/run_calc.pyto require explicitgeomandbasisarguments, clarified docstrings, and replaced theold_fanpyflag withfanpy_onlyfor clearer intent. Improved the way geometry and other arguments are formatted and passed to subprocesses.Test coverage:
tests/test_scripts_gaussian_run_calc.pyandtests/test_scripts_pyscf_run_calc.pyto provide comprehensive testing for the CLI and Python interfaces of the calculation scripts, including error handling and file generation.run_calc.pyin the PySCF folder cannot be tested, as they are used to submit calculations to servers. Also, some of the features would require an interface that has the variational approach.