Design system overhaul: tokens, UI chrome, panel polish, icon redraw#96
Draft
mracette wants to merge 18 commits into
Draft
Design system overhaul: tokens, UI chrome, panel polish, icon redraw#96mracette wants to merge 18 commits into
mracette wants to merge 18 commits into
Conversation
…vincing glass panel
.icon-white/.icon-moon set fill (for the old filled-shape sprite artwork) as well as stroke; since fill/stroke are inheritable CSS properties, that fill flowed down and solid-filled Lucide's stroke-based outline paths, making icon-home/icon-info/icon-music render as solid blobs instead of line icons. Force fill back to none directly in Icon.tsx's render rather than touching the shared classes, which ToggleButtonView.tsx also depends on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three slices of the Soundscape design overhaul (all still separate from the full app-wide redesign — landing page, per-screen layout rework, and mobile/desktop specifics remain ahead).
Design system + shared UI chrome — implements
docs/superpowers/specs/2026-07-02-design-system-overhaul-design.md:MenuButtonContentWrapper) with a translucent tint + glow border — kept translucent so the WebGL scene stays visible behind open panels (a "fake glass" texture was tried and explicitly dropped after live testing showed it fought that principle).In-app panel polish — implements
docs/superpowers/specs/2026-07-02-in-app-panels-design.md:pillButtonstyle applied to HomePanel's Proceed button and EffectsPanel's preset/reset/randomize buttons.hotGreentoken instead of a hardcoded string.Icon redraw — implements
docs/superpowers/specs/2026-07-02-icon-redraw-design.md:lucide-react) for the 5 icons actually used in the shipped app (home, music, equalizer, plus, info) —MenuButtonParent.tsx/MenuButtonChild.tsxneeded zero changes.SocialIcons.tsx,SharingIcons.tsx,iconography.css.ts) — all of it was only reachable from a dev-only Studio story, unused in the live app..icon-white/.icon-moonclasses forcedfill(correct for the old solid-shape sprite artwork) which, via CSS inheritance, silently filled in Lucide's outline paths solid. Fixed locally inIcon.tsx's own render rather than touching those shared classes, whichToggleButtonView.tsxalso depends on for a genuinely solid-filled shape.No changes to interaction logic, audio-timing behavior, DOM structure beyond what's described above, typography, or the landing page.
Test plan
pnpm typecheckclean on every commit across all three slicespnpm lintclean (0 errors, same pre-existing warnings throughout)pnpm test:e2efull suite (40 tests) passing after every commit, and again after merging all three branches together