Add tests for make_config - #251
Open
sangeetabhatia03 wants to merge 10 commits into
Open
Conversation
steffilazerte
approved these changes
Jun 29, 2026
steffilazerte
left a comment
steffilazerte
left a comment
Collaborator
There was a problem hiding this comment.
Hi @sangeetabhatia03, this looks good to me! The only thing you might consider is adding a test of a correct make_config(). It may not be necessary if it's included in the main tests elsewhere, but would be a nice complete package of tests here.
Collaborator
|
Hi @sangeetabhatia03, looks good to me! @annecori, do you want to review as well or can we merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the
make_configfunction.