Conversation
* Make IterableBitset iterator compatible with C++20 * Fix compiler warnings for fast bernoulli and (un)signed size comparisons
M-Kusumgar
approved these changes
Jun 8, 2026
M-Kusumgar
left a comment
M-Kusumgar
left a comment
There was a problem hiding this comment.
All seems reasonable, nice bug fix as well, I'm a bit unsure about the allocator removal or even why you were allocating in the first place, I think I'm missing some context but otherwise all looks good!
Comment on lines
+37
to
+41
| using value_type = size_t; | ||
| using reference = size_t&; | ||
| using const_reference = const size_t&; | ||
| using difference_type = std::ptrdiff_t; | ||
| using size_type = std::size_t; |
There was a problem hiding this comment.
Just for my understanding, why were you allocating vs not now?
Member
Author
There was a problem hiding this comment.
This was written when C++14 was the default and std::allocator members were a thing. In c++17 they were deprecated because they are redundant. And in C++20 they were removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fast_bernoulliwhere the probability member is unintentionally shadowed