Add seed nodes option to ydbd#1
Open
mregrock wants to merge 5 commits into
Open
Conversation
Owner
Author
|
BugBot run |
There was a problem hiding this comment.
Bug: Infinite Retry Loop in Config Fetching
The FetchConfigImpl method in TDefaultConfigClient contains an infinite retry loop. The while (!result.IsSuccess()) loop lacks a timeout or maximum retry limit. This causes the application to hang indefinitely during initialization if the provided address list is empty (e.g., from an empty seed nodes file []) or if all addresses are unreachable or consistently fail.
ydb/core/config/init/init.cpp#L466-L489
ydb/ydb/core/config/init/init.cpp
Lines 466 to 489 in e76b6fd
BugBot free trial expires on June 9, 2025
You have used $0.00 of your $0.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
mregrock
force-pushed
the
seed_nodes
branch
2 times, most recently
from
June 5, 2025 19:11
176a9fa to
04269eb
Compare
mregrock
pushed a commit
that referenced
this pull request
Jun 27, 2025
commit_hash:5b246144e81555f1bc12b2c8ca111e351dcd5ed7
mregrock
pushed a commit
that referenced
this pull request
Aug 1, 2025
https://github.com/yandex/toolchain-registry/releases/tag/clang20-v1 commit_hash:c4ed5a7b8a5529269a0fd2fc59e360964306e789
mregrock
pushed a commit
that referenced
this pull request
Sep 29, 2025
```
WARNING: ThreadSanitizer: data race (pid=123179)
Read of size 8 at 0x0000065aad98 by thread T14:
#0 NSystemInfo::CachedNumberOfCpus() util/system/info.cpp:241:10 (taxi-uservices-userver-core-tests+0x4155bba)
#1 engine::(anonymous namespace)::TaskProcessorThreadStartedHook() userver/core/src/engine/task/task_processor.cpp:100:15 (taxi-uservices-userver-core-tests+0x5306bc8)
ydb-platform#2 engine::TaskProcessor::PrepareWorkerThread(unsigned long) userver/core/src/engine/task/task_processor.cpp:347:5 (taxi-uservices-userver-core-tests+0x5306bc8)
```
The change on a hot path is equivalent to the previously compiler generated x86 code (just a `load` instruction). On other platforms this could actually fix a data race.
commit_hash:acb1fe1b8f3075cc27b18aab4f1bd0b88292c270
mregrock
pushed a commit
that referenced
this pull request
Jan 12, 2026
commit_hash:7afedb08035fd3cd26143d1448bf94cc6dbc3f8c
mregrock
pushed a commit
that referenced
this pull request
Jan 19, 2026
<https://github.com/yandex/toolchain-registry/releases/tag/gdb17-v1> (https://nda.ya.ru/t/OcY6idk77RsH6E commit_hash:baff0ad07b0406643106a76686885e0fe330addb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog entry
Add seed nodes option to ydbd
Changelog category
Description for reviewers
...