Repository navigation
Benchmark against pyDOE - #42
Draft
mrhheffernan wants to merge 2 commits into
Draft
mrhheffernan wants to merge 2 commits into
mrhheffernan wants to merge 2 commits into
Conversation
…me parameter adjusting
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Enables some basic benchmarking against pyDOE's maxpro implementation from ~3 months ago, finds a comparably optimal result 6x faster, meaning 6x more iterations can be performed in the same runtime if looking for an optimal result.
Also identifies that pyDOE only calculates the inner inverse product sum. Would need to expose the maxpro sum function from rust to do a direct comparison, which would only be of half the definition.
Testing:
Impacts: