Same Name File - #507
Open
jjdltc wants to merge 1 commit into
Open
Conversation
…riteInterfaceFile" from "convertFromDirectory"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 9 9
Lines 684 684
Branches 275 266 -9
=======================================
Hits 673 673
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I was using your package and face a few struggles with files that share the same name (
convertFromDirectory), I made small change that seems to work for my specific use case (Just compare based on the full path).TBH, Not sure if this breaks something or if goes in a direction different that the one you envisions for your project, if that's the case, apologies.
Regards.
tweak(same-file-name): Update to allow same file name when writing "writeInterfaceFile" from "convertFromDirectory"