Skip to content

fix(studio): sole workspace owner can reveal non-personal pending proposals and clarifications #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mroops0111 wants to merge 1 commit into from
Closed

fix(studio): sole workspace owner can reveal non-personal pending proposals and clarifications #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/studio/src/pages/Clarification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { Button } from '@/components/ui/button'
import { FILTER_TAB_TRIGGER, FILTER_TABS_LIST } from '@/components/ui/filterTabs'
import { Tabs, TabsList, TabsTrigger } from '@/components/ui/tabs'
import { api } from '@/lib/api'
import { queryKeys, useClarificationByStatus, useClarificationDetail, usePendingClarification, useWorkspaceMembers } from '@/lib/queries'
import { queryKeys, useClarificationByStatus, useClarificationDetail, usePendingClarification } from '@/lib/queries'
import { useGraphNavigation } from '@/lib/useGraphNavigation'
import { useTabNavigation } from '@/lib/useTabNavigation'
import { useWorkspacePolicy } from '@/policy'
Expand Down Expand Up @@ -285,10 +285,9 @@ function ClarificationShowAllToggle({
onToggle: (next: boolean) => void
}) {
const { effectiveRole } = useWorkspacePolicy(workspaceId)
const { data: members } = useWorkspaceMembers(workspaceId)
// Nothing to disambiguate on a solo workspace, every question is yours.
const multiMember = (members?.items.length ?? 0) > 1
if (effectiveRole !== 'owner' || status !== 'pending' || !multiMember)
// A solo workspace still holds questions owned by no member, automation and
// agents submit as `system`, so the owner needs the toggle whatever the size.
if (effectiveRole !== 'owner' || status !== 'pending')
return null
return (
<Button
Expand Down
9 changes: 4 additions & 5 deletions packages/studio/src/pages/Proposals.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { Button } from '@/components/ui/button'
import { FILTER_TAB_TRIGGER, FILTER_TABS_LIST } from '@/components/ui/filterTabs'
import { Tabs, TabsList, TabsTrigger } from '@/components/ui/tabs'
import { api } from '@/lib/api'
import { queryKeys, useProposalsByStatus, useProposalValidation, useWorkspaceMembers } from '@/lib/queries'
import { queryKeys, useProposalsByStatus, useProposalValidation } from '@/lib/queries'
import { useGraphNavigation } from '@/lib/useGraphNavigation'
import { useMutualExclusionPair } from '@/lib/useMutualExclusionPair'
import { useWorkspacePolicy } from '@/policy'
Expand Down Expand Up @@ -202,10 +202,9 @@ function ShowAllToggle({
onToggle: (next: boolean) => void
}) {
const { effectiveRole } = useWorkspacePolicy(workspaceId)
const { data: members } = useWorkspaceMembers(workspaceId)
// Nothing to disambiguate on a solo workspace, every proposal is yours.
const multiMember = (members?.items.length ?? 0) > 1
if (effectiveRole !== 'owner' || status !== 'pending' || !multiMember)
// A solo workspace still holds proposals owned by no member, automation and
// agents submit as `system`, so the owner needs the toggle whatever the size.
if (effectiveRole !== 'owner' || status !== 'pending')
return null
return (
<Button
Expand Down
Loading