Chore: Drop non-asdf version managers - #87
Closed
mrsauravsahu wants to merge 2 commits into
Closed
mrsauravsahu wants to merge 2 commits into
mrsauravsahu wants to merge 2 commits into
Conversation
asdf covers node, python, go, terraform and dotnet through plugins, so
the standalone installers duplicated it. nvm, pyenv, gvm and tfenv were
already flagged deprecated in favour of asdf; this removes them along
with dotnet.
Removed:
- src/installers/{gvm,nvm,pyenv,tfenv,dotnet}.{install,configure}.zsh
- src/extras/nvmrc-support.zsh, nvm-only and sourced by nothing
Wiring:
- read-options.zsh: dotnet dropped from the default tool set
- configure.zsh: removed tools dropped from the configure list
- tool-guards.zsh: DEPRECATED_TOOLS held only these five, and the
invalid-tool check in read-options exits before validate_tools runs,
so the deprecation warning was unreachable - removed
--tools now rejects the removed names via the existing installer-file
check; no new validation was needed.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017opPVGYfryqcV8BAt66zqW
Resolves the modify/delete conflict on src/utils/tool-guards.zsh by keeping main's deletion. This branch's commit edited the file to strip the dead DEPRECATED_TOOLS block; main removed the file outright in #85, which supersedes that edit. Nothing references tool-guards.zsh any more. The merge result is identical to origin/main - this branch's content was already merged via the squash of #85. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017opPVGYfryqcV8BAt66zqW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asdf covers node, python, go, terraform and dotnet through plugins, so the standalone installers duplicated it. nvm, pyenv, gvm and tfenv were already flagged deprecated in favour of asdf; this removes them along with dotnet.
Removed:
Wiring:
--tools now rejects the removed names via the existing installer-file check; no new validation was needed.