Skip to content

Update to include torch 1.13 release change - #1

Open
minsii wants to merge 2 commits into
mrshenli:mainfrom
minsii:pr-1.13-update
Open

Update to include torch 1.13 release change#1
minsii wants to merge 2 commits into
mrshenli:mainfrom
minsii:pr-1.13-update

Conversation

@minsii

@minsii minsii commented Oct 25, 2022

Copy link
Copy Markdown

It covers two changes in c10d introduced in torch 1.13:

How to test:

  1. Download a RC wheel from https://github.com/pytorch/pytorch/suites/8933836327/artifacts/410128673 including both changes
  2. pip3 install --pre torch --force-reinstall torch-1.13.0.dev20221024+cpu-cp39-cp39-linux_x86_64.whl
  3. python3 setup.py install
  4. python3 example.py

It covers two changes in c10d introduced in torch 1.13:
- Extract ProcessGroup::Work into a separate class
  refer to pytorch/pytorch#83680
- Install c10d headers with absolute path
  refer to pytorch/pytorch#86933
It allows to `python3 example.py` on a CPU-only machine
minsii added a commit to minsii/tutorials that referenced this pull request Oct 25, 2022
It covers two changes of c10d introduced in torch 1.13:
- Extract ProcessGroup::Work into a separate class, refer to pytorch/pytorch#83680
- Install c10d headers with absolute path, refer to Install pytorch/pytorch#86933

The tutorial code has also been updated at mrshenli/dummy_collectives#1
minsii added a commit to minsii/tutorials that referenced this pull request Oct 25, 2022
It covers two changes of c10d introduced in torch 1.13:
- Extract ProcessGroup::Work into a separate class, refer to pytorch/pytorch#83680
- Install c10d headers with absolute path, refer to Install pytorch/pytorch#86933

The tutorial code has also been updated at mrshenli/dummy_collectives#1

@H-Huang H-Huang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

svekars pushed a commit to pytorch/tutorials that referenced this pull request Oct 26, 2022
It covers two changes of c10d introduced in torch 1.13:
- Extract ProcessGroup::Work into a separate class, refer to pytorch/pytorch#83680
- Install c10d headers with absolute path, refer to Install pytorch/pytorch#86933

The tutorial code has also been updated at mrshenli/dummy_collectives#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants