Skip to content

Improve Forge auth error guidance for PR flow #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrychlik wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve Forge auth error guidance for PR flow #15

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef8d031
Improve Forge auth error guidance for PR flow
mrychlik Feb 21, 2026
3e4646f
Preflight Forge auth-source credentials for PR creation
mrychlik Feb 21, 2026
7305ea2
Merge branch 'main' into codex/check-forge-create-pullreq-usage-in-ag…
mrychlik Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions agentic.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,33 @@ Never returns nil; unreadable files yield \"\"."
;; Forge: open PR
;; -------------------------------------------------------------------

(defun agentic--forge-credentials-help ()
"Return short setup instructions for Forge/GitHub credentials."
(string-join
'("Forge authenticates to GitHub via `ghub` and `auth-source`."
"Add a Personal Access Token entry such as:"
" machine api.github.com login YOUR_GITHUB_USERNAME^forge password YOUR_TOKEN"
"(`login USERNAME^forge` is recommended so Forge/ghub can select the token reliably.)"
"Store it in `~/.authinfo.gpg` (recommended) or another file from `auth-sources`."
"You can also run `M-x ghub-create-token` to generate/store a token interactively.")
"\n"))


(defun agentic--forge-auth-source-configured-p ()
"Return non-nil when auth-source has a likely GitHub token for Forge/ghub."
(and (require 'auth-source nil t)
(or (auth-source-search :host "api.github.com" :max 1 :require '(:secret))
(auth-source-search :host "github.com" :max 1 :require '(:secret)))))

(defun agentic--signal-forge-auth-error (err)
"Raise a user-facing Forge authentication error from ERR."
(let ((msg (error-message-string err)))
(if (string-match-p "[Bb]ad credentials\\|401\\|403" msg)

@chatgpt-codex-connector chatgpt-codex-connector Bot Feb 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restrict auth classification to credential-specific failures

Matching on bare 403 causes non-auth GitHub failures (for example rate limiting or repository authorization errors) to be rewritten as credential setup problems, which hides the real cause and sends users toward the wrong fix. This regression is introduced in the new auth helper, where any message containing 403 is treated as bad credentials.

Useful? React with 👍 / 👎.

(user-error "agentic: Forge authentication failed (%s).\n\n%s"
msg
(agentic--forge-credentials-help))
(signal (car err) (cdr err)))))

;;;###autoload
(defun agentic/forge-open-pr ()
"Open a GitHub pull request for the current branch via Forge.
Expand All @@ -607,6 +634,9 @@ Forge's submit buffer, matching `forge-create-pullreq`'s documented workflow."
(progn (call-interactively #'forge-add-repository)
(forge-get-repository t)))))
(unless repo (user-error "agentic: no Forge repository configured"))
(unless (agentic--forge-auth-source-configured-p)
(user-error "agentic: no GitHub credentials found in `auth-source`.\n\n%s"
(agentic--forge-credentials-help)))
(magit-push-current-to-pushremote nil)
(forge-create-pullreq)
(message "agentic: PR submit buffer opened (complete title/body in Forge).")))
Expand Down