fix(ci): liczba na badge blast-radius czytana jako liczba, nie jako kod - #162
Merged
Merged
Conversation
The first badge this workflow ever published read "24960 files". The grouping came from printf "%'d", which does not group in the C locale the runner uses, and nobody had seen the output before because the step had never once run to completion. This is the headline number of the entire blast-radius argument. "24 960" reads as a quantity; "24960" reads as an identifier. Grouped with sed instead, which does not care about the locale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pierwszy badge, jaki ten workflow w ogóle opublikował, brzmiał
24960 files. Grupowanie pochodziło zprintf "%'d", które w localeCużywanym przez runnera po prostu nie grupuje — a nikt tego wcześniej nie widział, bo krok nigdy nie dobiegł do końca.To jest nagłówkowa liczba całej narracji o skali problemu.
24 960czyta się jak wielkość,24960jak identyfikator.Grupowanie przez
sed, niezależne od locale. Przetestowane:24960 → 24 960,22080 → 22 080,999 → 999,1234567 → 1 234 567.