Skip to content

Comments

Mark compatible with termcolor 3#141

Closed
ekohl wants to merge 1 commit intomsiemens:masterfrom
ekohl:allow-termcolor-3
Closed

Mark compatible with termcolor 3#141
ekohl wants to merge 1 commit intomsiemens:masterfrom
ekohl:allow-termcolor-3

Conversation

@ekohl
Copy link
Contributor

@ekohl ekohl commented Jul 11, 2025

The breaking changes do not affect git-up.

Link: https://github.com/termcolor/termcolor/releases/tag/3.0.0

GitPython = "^3.0.0"
colorama = "^0.4.0"
termcolor = "^2.0.0"
termcolor = ">= 2.0.0, < 4.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend no upper pin.

Here's a long explanation: https://iscinumpy.dev/post/bound-version-constraints/

Suggested change
termcolor = ">= 2.0.0, < 4.0.0"
termcolor = ">= 2.0.0"

@msiemens
Copy link
Owner

Thanks for the PR! I’ve updated dependencies during a recent refresh, which includes handling termcolor compatibility. Closing since this change is now covered in the updated dependency setup.

@msiemens msiemens closed this Dec 27, 2025
@ekohl ekohl deleted the allow-termcolor-3 branch December 28, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants