Drop price_type from the sample config - #61
Merged
Conversation
Follows cotmetrics, which removed CotIndexer.load_price_config, the only thing that read this key. It selected "close" against "settlement" for daily estimation, and since ADR-0007 there is nothing to select between: stored bars carry no settlement column, because both futures providers already put settlement in Close. Stacked on the flow_caps removal, and the two tombstones merge into one comment so the file explains both keys in one place. Suite 437 passed against the modified cotmetrics. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #60, and pairs with cotmetrics PR #30, which removes
CotIndexer.load_price_config— the only thing that ever read this key.price_typeselected"close"against"settlement"for daily estimation. It had no consumer in any surviving checkout, and since ADR-0007 it has nothing left to select between: stored bars carry no settlement column, because both futures providers already put settlement in Close (Norgate natively, databento via_with_settlement, which overrides Close withstat_type3 specifically so the series matches Norgate).Stacked on the
flow_capsremoval, so the two tombstones merge into one comment and the file explains both retired keys in one place.Verification
PYTHONPATHso it tests PR The admin page works again, and the store poller runs where it can matter #30's tree, not the installed checkout).config/params.yamlbefore/after:removed=['price_type'],changed=[], so no other key moved.Config-only change. No app code reads either key.
🤖 Generated with Claude Code