Stop the Windows bar wrapper discarding the finals gate's answer

[mspinola]

Found on the real Windows box while repointing it after the ADR-0007 removals.

The bug

The wrapper this repo ships ran --metadata straight after --bars with no guard, and a .cmd exits with the code of its last command:

"...marketdata-update.exe" --bars --domain futures --require-final   REM exits 1 on a defer
"...marketdata-update.exe" --metadata                                REM exits 0

So a deferral's exit 1 was overwritten by --metadata's exit 0. Task Scheduler recorded success, restart-on-failure never fired, and the task waited until the next day having fetched nothing.

That is exactly the failure --require-final exists to prevent, reintroduced one layer out: the gate computed the right answer every night and the wrapper threw it away. Same symptom this whole migration keeps producing — a green run that did nothing.

The fix

"%MDEXE%" --bars --domain futures --require-final
if errorlevel 1 exit /b %ERRORLEVEL%

"%MDEXE%" --metadata
exit /b %ERRORLEVEL%

Skipping --metadata on a defer is deliberate, not just convenient. Restart-on-failure turns this task into a poll loop, and each retry should be the cheap date compare the gate is — not a full contract-spec fetch of all 49 symbols against NDU.

Why if errorlevel 1 and not ||. if errorlevel 1 tests >= 1 and needs no variable expansion, so it is safe on one line. || exit /b %ERRORLEVEL% would not be, and it is worth naming because it is the obvious thing to reach for: cmd expands %ERRORLEVEL% when it parses the line, before the command on that line has run, so it returns the previous command's code. On its own line, after the command, it is correct.

Also adds setlocal and quotes the set, matching the other wrappers.

Verification, and its limit

There is no cmd in this sandbox, so this is reasoned from cmd's parse-time expansion rules, not executed. What I did check rather than remember: the Python exit codes on the other side — a deferral returns 1, --metadata returns 0.

Confirm on the box with Last Run Result on a deferred run: it must be 0x1, not 0x0.

ruff clean, 199 pass (docs/examples only — no source touched).

---

Generated by Claude Code