Skip to content

rename namespace pollution meson option and define in config.h#165

Merged
rdmark merged 1 commit intomainfrom
old-api
Mar 29, 2026
Merged

rename namespace pollution meson option and define in config.h#165
rdmark merged 1 commit intomainfrom
old-api

Conversation

@rdmark
Copy link
Copy Markdown
Collaborator

@rdmark rdmark commented Mar 29, 2026

the new option name emphasizes the enabling of backwards compatibility API macros, which is a more constructive and actionable than 'namespace pollution'

meson previously defined BSTRLIB_REDUCE_NAMESPACE_POLLUTION as a compiler option, but now we use config.h instead for transparency

@rdmark rdmark requested a review from msteinert as a code owner March 29, 2026 07:39
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2026

File Coverage Lines Branches
All files 69% 74% 63%
bstring/bstraux.c 55% 64% 47%
bstring/bstrlib.c 74% 78% 71%
bstring/buniutil.c 80% 86% 73%
bstring/utf8util.c 60% 71% 50%

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 68cf5f5

the new option name emphasizes the enabling of backwards compatibility API macros, which is a more constructive and actionable than 'namespace pollution'

meson previously defined BSTRLIB_REDUCE_NAMESPACE_POLLUTION as a compiler option, but now we use config.h instead for transparency
@sonarqubecloud
Copy link
Copy Markdown

@rdmark rdmark changed the title rename namespace pollution meson option rename namespace pollution meson option and define in config.h Mar 29, 2026
@rdmark rdmark merged commit 45eb433 into main Mar 29, 2026
21 checks passed
@rdmark rdmark deleted the old-api branch March 29, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant