Adding mTLS support - #507
Draft
mintsoft wants to merge 2 commits into
Draft
Conversation
…unt class so we can support mutual TLS
mintsoft
marked this pull request as draft
August 16, 2026 14:53
Owner
|
Hi, I think allowing users to select a file via filesystem path is not a good idea for security reasons. If one user knows the certificate path of another one, they could use it for their own addressbooks, as all needs to be accessible to the php user. |
Author
|
This is true, however these should be protected by a password (which would also be set in the UI) so just knowing a file path isn't sufficient. I've not extended this implementation to include that yet but it's next on the list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still in-progress/untested; will depend on mstilkerich/carddavclient#38