Fix cmake and Cython compile issues; update GH Action CI; extend support for python 3.12, 3.13, 3.14 - #202
Merged
Merged
Conversation
Owner
Author
|
The reported GreatCMakeCookOff PythonInstall.cmake CMP0148 warning when running ...
-- Building the galario python wrapper
CMake Warning (policy) at build/external/src/GreatCMakeCookOff/scripts/PythonInstall.cmake:3 (find_package):
Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules
are removed. Run "cmake --help-policy CMP0148" for policy details. Use
the cmake_policy command to set the policy and suppress this warning.
Call Stack (most recent call first):
python/CMakeLists.txt:52 (include)
This warning is for project developers. Use -Wno-author or -Wno-policy to
suppress it.
...comes from the current master version of python/CMakeLists.txt, which still includes the legacy PythonInstall helper. This PR replaces that helper with a Python-standard-library installation-path calculation, removing both that warning source and the distutils dependency that blocks Python 3.12+. Separate CMP0148 warnings may remain from the legacy FindCython.cmake and UseCython.cmake modules. They are not blockers for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #200 and addresses #201.
Build and compatibility
Linux installation coverage
CI and documentation
Validation
CUDA
CUDA configuration and GPU targets are unchanged. The Docker harnesses intentionally configure CPU-only builds because they run without an NVIDIA toolkit or GPU. GPU compilation remains to be validated on a compatible NVIDIA runner.
Follow-up
The legacy FindCython.cmake and UseCython.cmake modules can still emit CMP0148 policy warnings with recent CMake; modernizing those modules is intentionally deferred.