elmo branch #395
Open
elmo branch #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
the-muppet
commented
Nov 14, 2025
the-muppet
commented
- Adds robust product categorization logic
- Adds product distro data scraper for product data and additional metadata such as product configurations/descriptions.
Introduces rule-based and fuzzy categorization for product names and item numbers, enhancing accuracy and flexibility when classifying products. Supports confidence scoring and uses item number hints to improve reliability in ambiguous cases. Enables extensible training for future product data.
product data and additional metadata such as product configurations/descriptions. Automatically generates structured JSON and YAML files for downstream use.
Introduces an automated process for reading review data, categorizing products with confidence levels, and outputting updated results. Improves efficiency and consistency in product review handling.
Contributor
Author
|
process_review.py just tackles data/review.yaml if thats easier for the time being |
Introduces caching for Scryfall data to reduce API calls Implements name normalization and fuzzy grouping for sets Uses dataclasses for better data modelin. Adds logging for debugging and monitoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.