Repository navigation
feat: add blob HTTP endpoints (unit 8) - #54
Merged
Merged
Conversation
PUT/GET /vaults/{name}/blobs/{id}, wired behind APIKeyAuth. PutBlob
hashes the body (SHA-256) and rejects a mismatch against the claimed
id, short-circuits with 200 if the vault already has that blob (no
disk write), otherwise writes via blobstore and records the row via
store.PutBlob. GetBlob 404s on blobstore.ErrNotFound and streams the
bytes back. store.HasBlob/PutBlob/GetBlob and the Store interface in
http.go were fixed to key off vault_id (matching the blobs table's
actual primary key) instead of user_id, and PutBlob no longer takes
raw content bytes (the blobs table has no such column) - just
size_bytes.
Verified end-to-end locally with a real file over curl: hash
mismatch, dedup short-circuit, not-found, and cross-user vault
scoping all behave as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PUT/GET /vaults/{name}/blobs/{id}, wired behind APIKeyAuth. PutBlob hashes the body (SHA-256) and rejects a mismatch against the claimed id, short-circuits with 200 if the vault already has that blob (no disk write), otherwise writes via blobstore and records the row via store.PutBlob. GetBlob 404s on blobstore.ErrNotFound and streams the bytes back. store.HasBlob/PutBlob/GetBlob and the Store interface in http.go were fixed to key off vault_id (matching the blobs table's actual primary key) instead of user_id, and PutBlob no longer takes raw content bytes (the blobs table has no such column) - just size_bytes.
Verified end-to-end locally with a real file over curl: hash mismatch, dedup short-circuit, not-found, and cross-user vault scoping all behave as expected.