Repository navigation
Make vault name matching case-insensitive - #71
Closed
dyk1454683243-sudo wants to merge 1 commit into
Closed
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
Lookups, deletes, and uniqueness checks now treat vault names as case-insensitive on both the server and in local config. Stored names keep their original casing so existing config, keyring entries, and database rows are unchanged. Fixes #59 Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/case-insensitive-vault-names-5558
branch
from
September 18, 2026 07:42
90278d0 to
5219db7
Compare
Repository owner
locked and limited conversation to collaborators
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59.
Vault name lookups, deletes, and uniqueness checks are now case-insensitive on the server and in local config. Stored names keep their original casing, so existing
config.jsonentries, keyring secrets, and database rows are left unchanged.Changes
CreateVault,VaultByName, andDeleteVaultcompare names withLOWER(name), sonotesandNOTESresolve to the same vault. Creates still persist the name as given; lookups return that stored casing.VaultByNameTODO. Create/get/delete endpoints inherit the store behavior.Config.Vault,AddVault,RemoveVault, andValidatetreat names as case-insensitive. After a match, push/pull/remove use the stored name so existing keyring entries still resolve.Tests
Adds coverage for case-insensitive create/lookup/delete in the store and HTTP handlers, local config matching,
vault-remove, and a push/pull round-trip that createsNotesthen fetches it asNOTES.