-
Notifications
You must be signed in to change notification settings - Fork 0
feat: afficher le nombre de contenu non lus dans la barre latérale dans /feeds #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mtlaso
wants to merge
13
commits into
master
Choose a base branch
from
nb-elements-non-lus-feeds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
97180bc
chore: retirer variable inutile
mtlaso 32caa6a
feat: afficher le nombre d'éléments non lus sur les flux dans des dos…
mtlaso cbb577c
feat: afficher le nombre d'éléments non lus sur les flux qui ne sont …
mtlaso d5f68fb
feat: afficher le nombre d'éléments non lus sur les flux dans la barr…
mtlaso 91ed416
fix: filiter aussi par utiliser dans le `leftJoin`, car plusieurs uti…
mtlaso 13859fd
feat: optimistic updates du compte du nombre d'éléments restants à êt…
mtlaso b477ffe
fix: inverser updateReadCount
mtlaso 2c65bd8
feat: reset les delatas une fois l'action terminee
mtlaso 523b09d
fix: fixxxxxx bichhh
mtlaso 5b54c94
utiliser contexte pour afficher le nb total d'element
mtlaso 08064d0
fix: flash
mtlaso 430a7cd
fix: retirer clear
mtlaso 80b861e
fix: afficher noms correctement
mtlaso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| // Project-local debug tasks | ||
| // | ||
| // For more documentation on how to configure debug tasks, | ||
| // see: https://zed.dev/docs/debugger | ||
| [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guard these optimistic toggles against re-entry.
Lines 91-95 and 144-148 apply the unread delta on every call, but
handleMarkAsRead()is also invoked from the link click at Line 225. Opening an already-read item—or double-clicking before the first mutation settles—will enqueue another delta even if the backend write is a no-op, which can leave the sidebar unread count off by one. Add a per-item in-flight / desired-state guard beforesetOptimisticUnread().🛠️ Possible fix
Also applies to: 140-148
🤖 Prompt for AI Agents