Skip to content

Fix for issue #29 - image downloading issue on some mobile networks #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yifengj wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for issue #29 - image downloading issue on some mobile networks #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 14 additions & 29 deletions ...ort-lib/src/main/java/com/github/ignition/support/images/remote/RemoteImageLoaderJob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,44 +89,29 @@ protected byte[] retrieveImageData() throws IOException {
URL url = new URL(imageUrl);
HttpURLConnection connection = (HttpURLConnection) url.openConnection();

// determine the image size and allocate a buffer
int fileSize = connection.getContentLength();
Log.d(LOG_TAG, "fetching image " + imageUrl + " (" + (fileSize <= 0 ? "size unknown" : Integer.toString(fileSize)) + ")");
Log.d(LOG_TAG, "fetching image " + imageUrl);

BufferedInputStream istream = new BufferedInputStream(connection.getInputStream());

try {
if (fileSize <= 0) {
Log.w(LOG_TAG,
"Server did not set a Content-Length header, will default to buffer size of "
+ defaultBufferSize + " bytes");
ByteArrayOutputStream buf = new ByteArrayOutputStream(defaultBufferSize);
byte[] buffer = new byte[defaultBufferSize];
int bytesRead = 0;
while (bytesRead != -1) {
bytesRead = istream.read(buffer, 0, defaultBufferSize);
if (bytesRead > 0)
buf.write(buffer, 0, bytesRead);
}
return buf.toByteArray();
} else {
byte[] imageData = new byte[fileSize];

int bytesRead = 0;
int offset = 0;
while (bytesRead != -1 && offset < fileSize) {
bytesRead = istream.read(imageData, offset, fileSize - offset);
offset += bytesRead;
}
return imageData;
}
byte[] imageData = null;
ByteArrayOutputStream buf = new ByteArrayOutputStream(defaultBufferSize);;
try {
byte[] buffer = new byte[defaultBufferSize];
int bytesRead = 0;
do {
bytesRead = istream.read(buffer, 0, defaultBufferSize);
if (bytesRead > 0)
buf.write(buffer, 0, bytesRead);
} while (bytesRead != -1);
imageData = buf.toByteArray();
} finally {
// clean up
try {
istream.close();
buf.close();
connection.disconnect();
} catch (Exception ignore) { }
}
return imageData;
}

protected void notifyImageLoaded(String url, Bitmap bitmap) {
Expand Down