docs(cli): spike chat and complete parity - #13
Merged
mudler merged 1 commit intoAug 1, 2026
Conversation
Correct the pinned-vLLM CLI inventory and define CPU-verifiable implementation leaves for remote chat/complete commands while preserving the existing local invocation. FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:gpt-5 [Codex]
Contributor
Author
|
Slack follow-up: the required PR-open notification was also attempted through the bundled secret-safe sender. With no configured channel, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Moves
SERVE-CLI-CHATfromINVENTORIEDtoSPIKEwith an accepted, CPU-only implementation design. No runtime command support is claimed by this PR.The pinned-source audit found a material inventory bug: vLLM
5559679229does ship bothchatandcompletethroughvllm/entrypoints/cli/openai.py. The prior matrix had stopped at the import list inmain.pyand incorrectly called them project extensions.Design selected
The spike chooses a dual-mode command family:
chatandcompleteover OpenAI HTTP/SSE, including URL/auth/model discovery, quick and interactive modes, chat history, streaming, and TTFT/TPSvllm-cli --model DIR --prompt TEXTform as an explicit compatibility aliashttplibandnlohmann::json, with no new dependencyRemote-only was rejected because it breaks the current library-first example. In-process-only was rejected because it does not mirror the pinned vLLM behavior.
Evidence
Pinned vLLM
5559679229bc961848b121ccdeaa8fa5d79bec98:vllm/entrypoints/cli/main.py:17-37,73-98vllm/entrypoints/cli/openai.py:30-100vllm/entrypoints/cli/openai.py:155-234vllm/entrypoints/cli/openai.py:237-312Local baseline:
examples/cli/main.cpp:1-207tests/capi/test_capi.cpp:567-711tests/capi/test_chat_prompt.cpp:37-89Verification
All CPU-only gates pass on commit
73566588538e4956141be640a9a1603280785f11:python3 scripts/check-agent-record.pyagent record OK: ENGINE=131 MODEL=327 QUANT=82 KERNEL=45 BACKEND=68python3 tests/scripts/test_agent_record.pypython3 scripts/check-doc-checkpoint.pypython3 tests/scripts/test_doc_checkpoint.pypython3 scripts/check-readme-structure.pypython3 tests/scripts/test_check_readme_structure.pygit diff --check HEAD^No source, header, CMake, test, README, model, kernel, fixture, generated artifact, GPU work, model download, or benchmark changed.
docs/BENCHMARKS.mdrecordsNOT APPLICABLEandbenchmark_binding=false.Slack
The required selection notification was attempted with the bundled secret-safe sender. No channel is configured; the only conventional target available (
#general) returnedchannel_not_found. No credential was read or exposed.