fix(ci): scan actual environment reads - #14
Open
localai-org-maint-bot wants to merge 1 commit into
Open
Conversation
Restrict the environment documentation inventory to literal names passed through the shipped environment-reader call family. Ignore comments and unrelated strings while retaining all 196 real reads, with RED-first mutation coverage for direct calls, wrappers, and false positives. FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:gpt-5 [Codex]
localai-org-maint-bot
force-pushed
the
codex/cpu-maintenance-20260801
branch
from
August 3, 2026 03:15
cc55fdd to
f629a22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check-env-doc.pyinventory literal names passed to actual environment-reader calls instead of every quotedVT_*/VLLM_*tokengetenv,std::getenv, plus the seven local reader wrappersDesign
I evaluated three approaches: comment stripping alone,
getenv-only matching, and a full C++ lexer. Comment stripping still counts unrelated constants;getenv-only matching was proven incomplete because 21 shipped reads go through local wrappers; a full parser is unnecessary for literal call-site inventory. The implemented middle ground is a small comment-aware scanner with an explicit, tested reader-call family. Adding a future wrapper requires adding it to the family and its mutation case.The shipped result remains 196 covered production reads, proving the precision fix does not drop current real reads. No production C/C++, model, kernel, build configuration, environment classification, README claim, GPU path, or benchmark behavior changes.
Verification
python3 -m unittest discover -s tests/scripts -p "test_*.py"(98 tests)python3 scripts/check-env-doc.py(196 reads covered)python3 scripts/check-agent-record.pypython3 scripts/check-doc-checkpoint.py --commit HEADpython3 scripts/check-readme-structure.pypython3 scripts/check-model-checklist.pypython3 scripts/check-fusion-consistency.pypython3 scripts/check-device-leakage.pygit diff-tree --check HEADBenchmark disposition
NOT APPLICABLE. This is CPU-only CI governance; no runtime path or performance axis changes.
FOLLOWING_AGENTS_PROTOCOL