docs(scheduler): spike chunked prefill parity - #16
Open
localai-org-maint-bot wants to merge 1 commit into
Open
Conversation
Backfill the pinned-vLLM contract, current implementation anchors, missing CPU test groups, dependencies, and staged correctness/performance gates for ENG-CHUNKED-PREFILL. FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:gpt-5 [Codex]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Moves
ENG-CHUNKED-PREFILLfromANCHOR-BACKFILLtoSPIKEwith an accepted, CPU-only contract for the already-shipped basic token-budget chunking slice. No runtime support claim advances and no executable file changes.Design selected
I evaluated three scopes:
This PR chooses option 3. The accepted spec covers prompt splitting by the remaining token budget, concurrent partial-prefill admission,
long_prefill_token_threshold, incomplete-prefill state/output behavior, and the chunking-disabled ordering gate. Multimodal boundaries, Mamba alignment and fine-grained prefix stops, DP prefill throttling, pooling policy, and configurable partial-prefill limits remain explicitly separate.The audit found three missing pin-era CPU behavioral groups before the existing implementation can advance: shared-budget partial requests, disabled-chunking ordering, and the 400/400/224 concurrent distribution with prefix caching on/off. GPU recipe definition and every-axis closure remain pending until that semantic CPU leaf passes.
Evidence
Pinned vLLM
5559679229bc961848b121ccdeaa8fa5d79bec98:vllm/config/scheduler.py:58-91,126-136,261-310vllm/v1/core/sched/scheduler.py:427-561vllm/v1/core/sched/scheduler.py:640-930vllm/v1/core/sched/scheduler.py:1845-1900tests/v1/core/test_scheduler.py:271-333,589-661,988-1020,1433-1517Local anchors and the CP0-CP3 breakdown are in
.agents/specs/chunked-prefill.md.Verification
All CPU/record gates pass on
a17b3816:python3 scripts/check-agent-record.py(ENGINE=131, MODEL=327, QUANT=82, KERNEL=45, BACKEND=68)python3 tests/scripts/test_agent_record.py(13 mutation tests)python3 scripts/check-doc-checkpoint.py --stagedand--commit HEADpython3 tests/scripts/test_doc_checkpoint.py(5 tests)python3 scripts/check-readme-structure.pypython3 tests/scripts/test_check_readme_structure.py(18 mutation tests)python3 scripts/check-model-checklist.pypython3 scripts/check-fusion-consistency.pypython3 scripts/check-device-leakage.pypython3 scripts/check-env-doc.pygit diff --cached --checkThis host has no
cmake; no build is claimed or required for this records-only change. No C/C++, CMake, test, fixture, model, kernel, generated artifact, README, or performance number changed.Benchmark disposition
NOT APPLICABLE (
benchmark_binding=false) for this records-only spike. The next executable reproduction is the CPU CP1 gate in the spec. Exact GPU workload/commands are recipe-definition PENDING until CP1 fixes the semantic workload.Slack
The required selection notification was attempted through the bundled secret-safe sender. No channel is configured;
#generalreturnedchannel_not_found. No credential was read or exposed.FOLLOWING_AGENTS_PROTOCOL