fix(ci): keep per-commit range gates uncancellable - #17
Open
localai-org-maint-bot wants to merge 2 commits into
Open
fix(ci): keep per-commit range gates uncancellable#17localai-org-maint-bot wants to merge 2 commits into
localai-org-maint-bot wants to merge 2 commits into
Conversation
FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:GPT-5 [Codex]
FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:GPT-5 [Codex]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Fixes a fail-open gap in
ROAD-V1-A6: the documentation-checkpoint and commit-protocol-tag jobs each validate a unique pushbefore..sharange, but job-levelcancel-in-progress: trueallowed a latermainpush to cancel the only run covering the earlier range.The fix removes cancellation only from those two range-scoped jobs. Workflow-level pull-request deduplication and every tree-scoped job remain unchanged.
Design selected
I evaluated three approaches:
This PR chooses option 3. The accepted spike and implementation plan are in
.agents/specs/ci-per-commit-gates.mdanddocs/superpowers/plans/2026-08-01-ci-per-commit-gates.md.TDD evidence
RED first: the new static invariant reported four violations,
concurrencyandcancel-in-progresson each protected job.GREEN: removing only the two job-level blocks makes the invariant pass. Mutation cases independently inject both forbidden keys into both jobs and prove the test rejects them.
Verification
CPU-only gates, all green:
python3 tests/scripts/test_ci_per_commit_gates.py(3 tests)python3 -m unittest discover -s tests/scripts -p 'test_*.py'(98 tests)python3 scripts/check-agent-record.pyplus 13 mutation testspython3 scripts/check-doc-checkpoint.py --stagedplus 5 mutation testsgit diff --cached --checkNo C/C++, build, runtime, model, kernel, fixture, README, lifecycle, support, GPU, download, or benchmark behavior changes. Benchmark disposition is
NOT APPLICABLE(benchmark_binding=false).Slack
The required selection notification was attempted through the bundled secret-safe sender. No channel is configured;
#generalreturnedchannel_not_found. No credential was read or exposed.FOLLOWING_AGENTS_PROTOCOL