fix(records): reject duplicate model rollup rows - #21
Open
localai-org-maint-bot wants to merge 1 commit into
Open
fix(records): reject duplicate model rollup rows#21localai-org-maint-bot wants to merge 1 commit into
localai-org-maint-bot wants to merge 1 commit into
Conversation
Make the architecture checklist checker reject duplicate lifecycle and Total rows instead of silently accepting the last parsed value. Add RED-first mutations and the required governance checkpoint records. FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:gpt-5 [Codex]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Totalrows instead of silently accepting the last parsed valueDesign
The parser keeps its existing small, pure API.
parse_rollup()now returns explicit duplicate-key diagnostics alongside the parsed counts. Rejecting duplicate binding rows is preferable to summing them because each lifecycle key andTotalmust have one authoritative snapshot row.This is
ROAD-V1-A6/CLAIM-MODEL-CHECKLIST-ROLLUP-UNIQUENESS. It changes no model matrix row, lifecycle, support claim, runtime code, README, or benchmark.Verification
1448e981: focused suite fails exactly 2/12, with both duplicate mutations returning no errorstests/scriptsPython suite: 97/97scripts/check-*.pyrepository checkers passgit diff --checkpassesThe unrelated Triton AOT shell mutation test cannot start on this host because
cmakeis not installed. No Triton, CMake, generated artifact, source, model, or runtime file is changed by this PR.