Implemented Res.Type() Initial Logic to Specify Content-Type HTTP Response Header.#70
Merged
Conversation
Implemented Res.Type() Initial Logic to Specify Content-Type HTTP Response Header.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Introduces the Type method on Res to derive and store a MIME type from various inputs, and adds corresponding table-driven tests.
- Adds
Res.Type(string) *Resto normalize extensions or full MIME types intores.ContentType. - Introduces
TestContentTypeto validate common mappings (json, html, text, xml, csv, image formats).
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| response.go | Implements Res.Type method with extension lookup and fallback logic. |
| response_test.go | Adds TestContentType to verify Type normalization across inputs. |
Comments suppressed due to low confidence (2)
response.go:265
- The comment says the header is set, but the method only updates
res.ContentType. Either update the doc to reflect the actual behavior or have the method also write tores.Headers["Content-Type"].
// Sets the `Content-Type` HTTP response header to the MIME type specified
response_test.go:323
- Tests verify
res.ContentTypebut don't assert that theHeadersmap is updated. Add an assertion onres.Headers["Content-Type"]to cover header-writing behavior.
if res.ContentType != tt.expected {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.