Adding fine grained azure groups thats allowed#1
Open
maartenschalekamp wants to merge 3 commits into
Open
Conversation
andy-g
approved these changes
Jun 3, 2022
andy-g
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @maartenschalekamp 👍
This allows you to specify an array of azure groups as part of the settings right?
Author
Thats correct, Ive added more details in the main comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when setting the
app.sso_azure_modetogroupsit will sync all groups from Azure (Security and Distribution groups). This also not handled very good on the ui when viewing the users as it will overflow and getting all the groups synced was not very useful for us.The suggested changes are the ability to select if you want only security groups or all groups, where currently all groups are forced. Usually security groups will be used for access control. Then also have a new list option to filter out which groups to be allowed to be synced.
These changes are really hard to test in a local dev environment as it requires a valid license.
So to completely make us of this feature you need to set the following.
So if the user logs in and they are assigned to security group
AD_GROUP_NAME_ONEorAD_GROUP_NAME_TWOit will be added to their profile.