S3 OLCI and SLSTR downloading added - #10
Open
GerardoLopez wants to merge 1 commit into
Open
GerardoLopez wants to merge 1 commit into
GerardoLopez wants to merge 1 commit into
Conversation
jgomezdans
reviewed
Jun 28, 2017
| if not input_sensor in sensor_list: | ||
| raise ValueError("Sensor can only be S1 or S2. You provided %s" | ||
| % input_sensor) | ||
| def download_sentinel(location, input_start_date, |
Collaborator
There was a problem hiding this comment.
Good, can you just name this function as download_sentinel3 or something like that? The idea is that we expose this as the main API. Also, if you fancy some py.test ;-)
Collaborator
There was a problem hiding this comment.
Bummer, maybe I didn't understand: did you extend the previous version that gets S1 and S2 to also do S3 as well, or does this version only do S3 (no probs either way, just want clarification)
Author
There was a problem hiding this comment.
I extended the functionality of the previous version to get S3 data as well :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.