backwards compatibility#25
Draft
dorin-iancu wants to merge 1 commit into
Draft
Conversation
sasurobert
approved these changes
Jul 11, 2022
psorinionut
approved these changes
Jul 11, 2022
sasurobert
requested changes
Jul 11, 2022
sasurobert
left a comment
sasurobert
left a comment
There was a problem hiding this comment.
Can you put this into a feat branch with backward comp ? as it is not really needed for all marketplaces. And the code become bigger.
Contributor
Author
I guess we can keep this as a draft PR. |
claudiu725
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually implement
TopDecodeforAuctionto check for the newly added field, populating it with the default 0 if not present.