feat(units): track struct field units through let bindings, call results and nested access - #541
Merged
Merged
Conversation
…lts and nested access Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
AkiraTamai
marked this pull request as ready for review
September 2, 2026 13:05
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #539 (review finding). The unit checker resolved
x.fieldonly whenxwas a parameter orresult;let p = Price {..}; p.jpy + usd,mk_price(u, j).jpy + usdandq.price.jpy + usdsilently passed as unitless.support/units.rsnow propagates a small type descriptor instead of a bare unit:struct_nameis seeded from param/-> Ttypes,Struct { .. }literals and callee return types, flows throughlet,if/matchbranches, andFieldAccesslooks the field up on the inferred target type (so nesting works). Unit compatibility rules are unchanged; arrays remain unitless (documented indocs/LANGUAGE.md).Fixtures:
tests/test_units_struct_ok.mm(positive) andtest_units_struct_mismatch_{let,call,nested}.mm(each rejected withUnit mismatch ... 'JPY' with 'USD'), wired intests/test_units.rs.Link to Devin session: https://app.devin.ai/sessions/2eef5afcd69d4e0ab19ada3b22d5cf7e
Open in Devin Desktop: https://app.devin.ai/desktop/session/2eef5afcd69d4e0ab19ada3b22d5cf7e?variant=devin
Requested by: @AkiraTamai