Skip to content

📝 Update templated files#1790

Closed
mqt-app[bot] wants to merge 2 commits into
mainfrom
update-mqt-templates-f48cb09ff49f5f100f8448cc350a60d2be734be8
Closed

📝 Update templated files#1790
mqt-app[bot] wants to merge 2 commits into
mainfrom
update-mqt-templates-f48cb09ff49f5f100f8448cc350a60d2be734be8

Conversation

@mqt-app

@mqt-app mqt-app Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This pull request updates the files in this repository with the latest changes from the MQT Templates repository.
For details on the respective changes, see the changelog as well as the upgrade guide.

@mqt-app mqt-app Bot added the documentation Improvements or additions to documentation label Jun 17, 2026
@denialhaag

denialhaag commented Jun 17, 2026

Copy link
Copy Markdown
Member

😞

I'll look into this in a bit once I'm back home.

@burgholzer

Copy link
Copy Markdown
Member

Interestingly, the changes do not only involve lines that are project specific, but also random lines throughout. We likely need to somehow synchronize the version of rumdl being used.

@denialhaag

Copy link
Copy Markdown
Member

Interestingly, the changes do not only involve lines that are project specific, but also random lines throughout. We likely need to somehow synchronize the version of rumdl being used.

I only did the debugging in my head now, but I think the problem is that we are not passing the working directory to subprocess.run(["prek", "run", ...], ...) in the templating script. Once we do that, the action should automatically use the .pre-commit-config.yaml of the target repository.

denialhaag added a commit to munich-quantum-toolkit/templates that referenced this pull request Jun 17, 2026
## Description

This PR fixes a bug encountered in
munich-quantum-toolkit/core#1790. Because `prek`
is not running from the current directory, it cannot find the pre-commit
and `rumdl` configurations in the target repository. This PR fixes this
by setting the `cwd` argument of `subprocess.run`.

## Checklist

- [x] The pull request only contains commits that are focused and
relevant to this change.
- [x] ~~I have added appropriate tests that cover the new/changed
functionality.~~
- [x] ~~I have updated the documentation to reflect these changes.~~
- [x] I have added entries to the changelog for any noteworthy
additions, changes, fixes, or removals.
- [x] ~~I have added migration instructions to the upgrade guide (if
needed).~~
- [x] The changes follow the project's style guidelines and introduce no
new warnings.
- [x] The changes are fully tested and pass the CI checks.
- [x] I have reviewed my own code changes.
@denialhaag

Copy link
Copy Markdown
Member

This PR was created in error due to a bug in version v1.3.0 of the templating action. This bug has been fixed in version v1.3.1. Closing this now.

@denialhaag denialhaag closed this Jun 17, 2026
@burgholzer burgholzer deleted the update-mqt-templates-f48cb09ff49f5f100f8448cc350a60d2be734be8 branch June 17, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants