Skip to content

fix(better-files): finish Windows badge preview and folder filtering - #38

Open
JulioLeonPhd wants to merge 7 commits into
munza:mainfrom
JulioLeonPhd:windows-better-files-followups
Open

JulioLeonPhd wants to merge 7 commits into
munza:mainfrom
JulioLeonPhd:windows-better-files-followups

Conversation

@JulioLeonPhd

@JulioLeonPhd JulioLeonPhd commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Windows Markdown previews fetch and cache web badges with PowerShell and Windows curl; the POSIX fetch path is unchanged.
  • On Windows, the filter can index a local folder outside Git without sh; the Git-backed path remains unchanged.

Closes #36.
Closes #37.

Evidence

  • Before: both paths called sh, which is absent on the Windows Box.
  • After: the Better Files suite passed on macOS. On the Windows Box over SSH, all 26 shell tests and four focused preview/index tests passed, including real Windows PowerShell traversal and a real badge download plus cache hit. The focused mod tests verify rendering and opening behavior with the Herdr API stubbed; the desktop UI was not tested.

Merge Danger

Door: Two-way; revert the PR to restore the previous behavior.

Blast radius: Better Files’ Markdown image fetch and non-Git filter index on Windows.

- Download Markdown web images through PowerShell on Windows without changing the POSIX curl path.
- Add Windows preview and loopback-fetch regression coverage.
- Fixes munza#36
# Conflicts:
#	better-files/tests/files.test.cjs
- Parenthesize depth arithmetic in PowerShell array construction.
- Add a Windows-only real PowerShell traversal regression.
- Restore the viewer’s POSIX fetch script and keep Windows URLs and paths out of PowerShell source.
- Bound Windows downloads with system curl and preserve cached output paths.
- Skip inaccessible index descendants and mark byte-limit truncation.
- Fix Windows regression coverage and update platform documentation.
Use URI encoding without browser globals, and retain the last complete index entry when Windows reports truncation.
@JulioLeonPhd
JulioLeonPhd marked this pull request as ready for review November 19, 2026 08:26

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better Files: Filter doesn’t index folders outside Git on Windows Better Files: Web badges don’t render in Markdown preview on Windows

1 participant