feat(combobox): keyboard support for editable and configurable signal and selected index change behavior - #80
Merged
Merged
Conversation
FramePerfection
added
bug
Collaborator
Author
|
@Aurumaker72 I can say that the behavior is now pretty much exactly what I'd want it to be, but the implementation is quite hacky. |
Member
|
Yo, thanks a lot for this! Makes so much more sense semantically. I can pick it up sure 👍 |
Member
|
The scope for this is too broad: the key navigation stuff is nice but should definitely be a separate PR. |
Member
|
Can you make a separate PR with just that? I can move the changes over to it if you want, but you should make the PR so you get the squash commit authorship |
FramePerfection
marked this pull request as ready for review
June 25, 2026 18:00
we dont want to commit the selection change while the user is perusing the listbox with up/down keys
abart27
force-pushed
the
fix/editable-combobox
branch
from
June 25, 2026 18:53
365224b to
ed70fe5
Compare
abart27
changed the title
editable and configurable signal and selected index change behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the
signal_changebehavior of comboboxes as follows:ongoingif the selected original index is different fromcontrol.selected_index, ornoneotherwise.control.selected_index, the value isendedstarted. Should maybe be changed.This enables users of the
ugui.comboboxAPI to react to theendedsignal_change, fixing usability issues that would arise from prematurely updating the value fed intocontrol.selected_index.Additionally, the up and down arrow keys may be used to move the selected index, and enter may be used to confirm the selection (i.e. close the listbox).