Skip to content

Update the BIP Process#2

Merged
murchandamus merged 153 commits into
masterfrom
2024-05-update-process
Dec 10, 2024
Merged

Update the BIP Process#2
murchandamus merged 153 commits into
masterfrom
2024-05-update-process

Conversation

@murchandamus
Copy link
Copy Markdown
Owner

@murchandamus murchandamus commented May 13, 2024

This BIP proposes a successor to BIP-2 by defining an updated BIP process.

murchandamus pushed a commit that referenced this pull request May 13, 2024
add clarifying note about the current opcode
@murchandamus murchandamus force-pushed the 2024-05-update-process branch from bf9aa75 to 30f1b8d Compare May 13, 2024 21:13
@murchandamus murchandamus force-pushed the 2024-05-update-process branch 4 times, most recently from 180c832 to f9017d4 Compare June 24, 2024 19:22
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
@murchandamus murchandamus force-pushed the 2024-05-update-process branch from 52469d0 to 0dceb9c Compare July 3, 2024 18:34
Comment thread bip-update-process.md Outdated
Copy link
Copy Markdown

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First (somewhat superfical) pass, didn't yet compare to BIP 2 or go deeper on the changes.

The "Changes from BIP-2" section is an excellent idea (didn't verify it yet).

Edits:

  • I like the statuses simplification
  • I dislike the "champions" usage, prefer "authors"
  • Would be good to use one single format, e.g. BIP2 vs BIP 2 vs BIP-2, in this BIP.

Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Copy link
Copy Markdown

@ajtowns ajtowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Copy link
Copy Markdown
Owner Author

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonatack and @ajtowns. Just some first comments, I’ll continue work on this on Friday.

Comment thread bip-update-process.md Outdated
## Rationale

[^astroturfing]: **What does it mean to be focused on Bitcoin the currency?**
Proposals to astroturf on the Bitcoin network to store data, bootstrap their own consensus mechanism, or facilitate
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to get rid of that underspecified requirement. Happy to add one or multiple concrete criteria that can be evaluated more objectively.

Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md
Comment thread bip-update-process.md Outdated
Copy link
Copy Markdown
Owner Author

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took most of the suggestions, except where otherwise stated or the comment is not resolved. I’ll try to get more input on the BSD-license thing and think more about the open comments.

Thanks for your input @jonatack and @ajtowns

Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
@murchandamus murchandamus force-pushed the 2024-05-update-process branch from d4cfee5 to b3bf8a1 Compare July 9, 2024 20:30
@murchandamus
Copy link
Copy Markdown
Owner Author

murchandamus commented Jul 9, 2024

I should now have addressed all the feedback

@murchandamus murchandamus force-pushed the 2024-05-update-process branch 3 times, most recently from 905571a to 1f3e27b Compare July 12, 2024 00:28
Copy link
Copy Markdown

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More soon.... :)

Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
@real-or-random
Copy link
Copy Markdown

Regarding scope, here's a different attempt:

  • "The scope of the BIPs repository is limited to BIPs that are not in conflict with the fundamental principle that Bitcoin constitutes a peer-to-peer electronic cash system."

Or a variant:

  • "The scope of the BIPs repository is limited to BIPs that are not in conflict with the fundamental principle that Bitcoin constitutes a peer-to-peer electronic cash system for the bitcoin currency.

It may be worth discussing this aspect (and other "large" topics) in separate issues.

@jonatack
Copy link
Copy Markdown

  • that are not in conflict

What constitutes "in conflict" may need clarifying.

Copy link
Copy Markdown

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP (will comment when I've finished reviewing this version).

Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md
@jonatack
Copy link
Copy Markdown

Note that the top-level README would need to be updated.

Copy link
Copy Markdown
Owner Author

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have addressed all review feedback, please let me know if I overlooked something. Still have a few open todos like the scope.

Comment thread bip-update-process.md
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md
Comment thread bip-update-process.md Outdated
@murchandamus
Copy link
Copy Markdown
Owner Author

Note that the top-level README would need to be updated.

I made updates to the README to match the new process.

@murchandamus murchandamus force-pushed the 2024-05-update-process branch 2 times, most recently from 2573a79 to 914b9a8 Compare September 16, 2024 22:26
@murchandamus
Copy link
Copy Markdown
Owner Author

But here's a variant, just a tiny bit more precise: "The scope of the BIPs repository is limited to BIPs that do not oppose the fundamental principle that Bitcoin constitutes a peer-to-peer electronic cash system for the bitcoin currency."

I think "do not oppose" raises the bar for rejecting a BIP a bit, at least more than "in conflict". For example, putting a technology on top of Bitcoin (e.g., colored coins) would be an okay topic for a BIP. The same is true for OpenTimestamps. These are prime examples that we should discuss and try to evaluate the rules against. If you ask me, all of these are fine, but others have disagreed in the past (e.g., @sipa -- please correct me if I'm wrong).

Sure, that seems at least as good as anything that I had so far.

@murchandamus murchandamus force-pushed the 2024-05-update-process branch from db4b6b1 to 7554714 Compare December 5, 2024 22:24
Copy link
Copy Markdown
Owner Author

@murchandamus murchandamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from @jonatack's request to comment here:

I would like an editor/champion field as per bitcoin#1482, clarifying the difference between authorship and helping out / point of contact for edits.

We could add a separate field "Proposers" (or "Proponents" or whatever you choose above), or even "Champions", which could be optional if it matches the "Authors" field. It sounds like a clean solution to me, and I lean towards it, but I wonder if it's slight overkill.

@JeremyRubin, @real-or-random: I introduced minimal changes to add a "Proponents" header, but to do it properly, I think it would require reworking several sections of the proposal. I’m not sure whether the distinction between Authors and Proponents occurs often enough and adds enough value to motivate the additional necessary changes.

Comment thread bip-update-process.md Outdated
Comment on lines +383 to +394
#### Recommended licenses

* BSD-2-Clause: [OSI-approved BSD 2-clause license](https://opensource.org/licenses/BSD-2-Clause)
* BSD-3-Clause: [OSI-approved BSD 3-clause license](https://opensource.org/licenses/BSD-3-Clause)
* CC0-1.0: [Creative Commons CC0 1.0 Universal](https://creativecommons.org/publicdomain/zero/1.0/)
* GNU-All-Permissive: [GNU All-Permissive License](http://www.gnu.org/prep/maintain/html_node/License-Notices-for-Other-Files.html)

#### Not recommended, but acceptable licenses[^licenses]

* CC-BY-4.0: [Creative Commons Attribution 4.0 International](https://creativecommons.org/licenses/by/4.0/)
* CC-BY-SA-4.0: [Creative Commons Attribution-ShareAlike 4.0 International](https://creativecommons.org/licenses/by-sa/4.0/)
* MIT: [Expat/MIT/X11 license](https://opensource.org/licenses/MIT)
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks that’s a nice simplification. I’ve folded "Recommended licenses" and "Not recommended acceptable lincenses" into "Acceptable licenses".

To be honest, the license aspect of the process is not my forte or at the center of my interests. I am more than happy to consider any further suggestions, especially simplifications to that aspect of the proposal.

Comment thread bip-update-process.md Outdated
Comment thread bip-update-process.md
Comment thread bip-update-process.md Outdated
@murchandamus
Copy link
Copy Markdown
Owner Author

murchandamus commented Dec 6, 2024

Okay, I think I should be caught up on all review comments that I could process. The major changes in this update:

  1. I decided to go with some of @ajtowns’s suggestions for the status header values. I replaced "Active" with "Deployed", and "Proposed" with "Complete". I also renamed "Abandoned" with "Closed" since multiple people commented on a perceived negative connotation of the former.
    @jonatack: While this now goes beyond just simplifying the Status field values, the new names are more descriptive and might help keeping BIPs updated to the correct statuses.

BIP-Process-Draft-Complete-Deployed-Closed

  1. I introduced a Proponents header to collect stand-ins for the original authors. I’m still on the fence on that one, I think a few more sections would need to be touched up to really make it work, and I’m not sure whether the field is useful often enough to motivate the additional changes.

  2. I updated the description of the purpose and scope of the BIP repository.

  3. I updated the description of Process BIPs.

  4. I renamed the "Author" header to "Authors" and use the plural throughout the document.

  5. I folded "Recommended Licenses" into the "Acceptable Licenses".

Beyond that there are many smaller changes to address all of your many excellent review comments. Thank you very much for all the review.

@murchandamus
Copy link
Copy Markdown
Owner Author

I finished reading my draft and started going through the document to make a few more edits. Please let me know if you have any other suggestions, otherwise, I will open a pull request to the BIP repository with the resulting version after I finish my edits.

@murchandamus
Copy link
Copy Markdown
Owner Author

Thanks @real-or-random, I addressed your comments from today.

@murchandamus murchandamus merged commit 8faa330 into master Dec 10, 2024
@murchandamus
Copy link
Copy Markdown
Owner Author

murchandamus commented Dec 10, 2024

I have opened a pull request to the BIP repository here: bitcoin#1712

0xsarawut

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.