Skip to content

fetching master - #1

Open
sakshi-arora1 wants to merge 532 commits into
muskgupta:ThemeEditorSupportfrom
adobe:master
Open

fetching master#1
sakshi-arora1 wants to merge 532 commits into
muskgupta:ThemeEditorSupportfrom
adobe:master

Conversation

@sakshi-arora1

Copy link
Copy Markdown

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

rismehta and others added 30 commits September 9, 2025 08:13
* FORMS-19439 adding support for display format in text input

* Fixing package lock

* Fixing test case

* Fixing design dialog inheritance

* Fixing test

* Fixing test

* Fixing test cases

* updating QS version

* Using 22450 image

* update wcm version

* Fixing test

* Fixing test

* Skipping test for now

* Commenting test
#1718)

* FORMS-21841: fix rule-editor tests and update custom function extraction from rules at runtime

* FORMS-21841: fix rule-editor tests and update custom function extraction from rules at runtime

* FORMS-21841: fix rule-editor tests and update custom function extraction from rules at runtime

---------

Co-authored-by: Arun Kumar Attri <aattri@adobe.com>
* fd:view type support in text and fragment localization test suite (#1706)

* fd:view type in text

* Adding dictionary

* Fixing Dynamic Checkbox and radio button misbehaviour. (#1711)

* FORMS-19439 adding support for display format in text input (#1714)

* FORMS-19439 adding support for display format in text input

* Fixing package lock

* Fixing test case

* Fixing design dialog inheritance

* Fixing test

* Fixing test

* Fixing test cases

* updating QS version

* Using 22450 image

* update wcm version

* Fixing test

* Fixing test

* Skipping test for now

* Commenting test

* FORMS-21841: fix rule-editor tests and update custom function extract… (#1718)

* FORMS-21841: fix rule-editor tests and update custom function extraction from rules at runtime

* FORMS-21841: fix rule-editor tests and update custom function extraction from rules at runtime

* FORMS-21841: fix rule-editor tests and update custom function extraction from rules at runtime

---------

Co-authored-by: Arun Kumar Attri <aattri@adobe.com>

---------

Co-authored-by: Rishi Mehta <69448117+rismehta@users.noreply.github.com>
Co-authored-by: sakshi-arora1 <80878797+sakshi-arora1@users.noreply.github.com>
Co-authored-by: Arun Kumar Attri <aattri@adobe.com>
* FORMS-21799 fixing aria-label to display plain text

* FORMS-21799 correcting naming convention

* FORMS-21799 adding tests

* FORMS-21799 increasing test coverage

* FORMS-21799 increasing test coverage

---------

Co-authored-by: Shivam Agarwal <shivama@adobe.com>
Feat: added the loader to avoid multiple submits and tests
* @releng updating af-core

* @releng updating af-core
* FORMS-21799 fixing aria-label to display plain text (#1715)

* FORMS-21799 fixing aria-label to display plain text

* FORMS-21799 correcting naming convention

* FORMS-21799 adding tests

* FORMS-21799 increasing test coverage

* FORMS-21799 increasing test coverage

---------

Co-authored-by: Shivam Agarwal <shivama@adobe.com>

* Merge pull request #1713 from adobe/FORMS-21742

Feat: added the loader to avoid multiple submits and tests

* Fixing js doc (#1721)

* @releng updating af-core (#1726)

* @releng updating af-core

* @releng updating af-core

---------

Co-authored-by: Shivam Agarwal <47965724+im-shiv@users.noreply.github.com>
Co-authored-by: Shivam Agarwal <shivama@adobe.com>
Co-authored-by: armaang1729 <armaang@adobe.com>
* modified the edit dialog for the checkbox to provide the value when checked for the boolean datatype

* modified the basic form having checkboxes of all datatypes along with the rules

* added the cypress test cases for all the datatypes(string, number, boolean) for checkbox having rule enabled for all of them

* replaced the common logic of checked value for the boolean datatype with the helper function

---------

Co-authored-by: Armaan Gupta <armaang@Armaans-MacBook-Pro.local>
* FORMS-18328 default date localization changes

* FORMS-18328 updating comment message

---------

Co-authored-by: Shivam Agarwal <shivama@adobe.com>
FORMS-18632: Info or functionality is unavailable at 320px width equivalent @sunnym @vavarshn
* guideBridge unload

* feat: unload

* Fixing unload

* unload test cases

* Fixing test and enhancing logic to auto deduce form if there  is only one form in the page

* improved js doc

* Simplifying API usage

* review comments

* Fixing test

* Removing container itself

* Review comments

* Fixing test

* Review comments
rismehta and others added 30 commits July 21, 2026 09:33
fix(af-core): stop dropping properties and properties.$path rule targets
[FORMS-26375] Update theme selector states for scribble component
…1929)

* FORMS-26630: Add show as popup property in guidecontainer model json

* FORMS-26630: Update show as popup test

* FORMS-26630: Move popup key out from condition
…File Attachment (#1943)

* Fix custom accept error message not shown for unsupported file type in file input

The file-input widget's invalidMessage() looked up
constraintMessages.invalidMimeType for the unsupported-file-type alert,
but invalidMimeType is not an authorable constraint message key - the
schema only exposes constraintMessages.accept (backed by the
acceptMessage dialog property). As a result the custom message
authors configure for file type validation was always ignored in
favor of the generic fallback string, while the analogous
maxFileSize custom message worked correctly since its key matched.

Updated both the webpack source (ui.frontend) and the apps clientlib
copy (ui.af.apps) to read constraintMessages.accept, and added a
Cypress assertion mirroring the existing maxFileSize custom-message
test.

* FORMS-26813 : populate sample.afe fixture so the unsupported-type test reaches the mime-type (accept) check instead of the empty-file check

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* FORMS-26813 : use existing sample.svg fixture on fileinput3 for the unsupported-type test

Point the accept test at fileinput3 (accept=[application/pdf]) and upload sample.svg
(an image, unsupported there) instead of populating a sample.afe placeholder. svg is
non-empty so it passes the empty-file check and reaches the mime-type (accept) check.
Matches the release/650 backport (#1940).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Farha Haroon <fharoon@adobe.com>
Co-authored-by: Mayank Jindal <mayankjindal@adobe.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* added theme editor support for table component

* updated README for the table component theme editor support

* address review comments for table theme editor styleConfig

- add hover, focus-visible, disabled states to tableAddButton and tableRemoveButton for consistency with tableSortButton
- use :focus-visible on sort button and add/remove buttons to match theme canvas SCSS

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Armaan Gupta <armaang@Armaans-MacBook-Pro.local>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
updating af2-web-runtime to v1.0.2
Adding File attachment scanning support.
…odes (#1957)

Change from sling:Folder to nt:unstructured so AEM resolves component
resource type inheritance correctly.

Co-authored-by: Armaan Gupta <armaang@Armaans-MacBook-Pro.local>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
[FORMS-27260] Removing datepicker v2 and updating a11y fixes in v1
…der (#1958)

* fixing the Filevault issue

* added jcr:primaryType=nt:unstructured to the child Nodes

---------

Co-authored-by: Armaan Gupta <armaang@Armaans-MacBook-Pro.local>
…race) (#1960)

A config-dialog submit fires an asynchronous editable re-render that
repositions overlays and hides the shared #EditableToolbar. The test
proceeded straight to openEditableToolbar, so the late re-render tore the
toolbar down after it was opened and the trailing should('be.visible')
(commands.js:311, never re-clicks) timed out with "#EditableToolbar has
display: none". At retries=0 this reproduced 4/5; masked but still ~41%
flaky at CI retries=3.

- Add central cy.submitConfigureDialog() command that registers the same
  cq-editables-updated + cq-overlays-repositioned listeners
  deleteComponentByPath uses BEFORE submit and blocks until both fire, so
  the editor is settled before the next openEditableToolbar. Reusable by
  the other submit sites across specs.
- Use it in the Forms-editor and Sites-editor flows of the spec.
- Suppress the intermittent CoralUI3 "Cannot create property '_namespace'
  on boolean 'true'" editor-bootstrap error in the index.js allow-list; it
  is racy, self-recovers, and has no functional impact on the form.

Verified: 20 consecutive post-fix runs at retries=0 with zero failures
(baseline 4/5 failing).

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adding component versioning requirements to ensure valid component version bumping
[FORMS-26375] Updating button main selector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.